test: split wasi poll test for windows #52538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
@nodejs/platform-windows |
github-actions
bot
removed
the
request-ci
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b41347e |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52538 Fixes: #51822 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52538 Fixes: #51822 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52538 Fixes: #51822 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to Visual Studio v17.9, the
test-wasi-pollstarted failing. Upon investigation, I discovered a bug in V8 and opened a CL in V8: https://chromium-review.googlesource.com/c/v8/v8/+/5438113Notably, some parts of the
poll.wasm(created usingpoll.c) are unsupported on Windows, as indicated here:node/test/wasi/c/poll.c
Lines 34 to 36 in 9efc84a
However, the bug in V8 enables these unsupported parts of the test to execute and makes the test fail.
In this PR, I've created a new
poll_win.wasmwhich will only be used on Windows until this bug is fixed upstream and ported to Node.Fixes: #51822