doc: add Rafael to steward list #52452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
benjamingr
approved these changes
Apr 10, 2024
MoLow
approved these changes
Apr 10, 2024
richardlau
approved these changes
Apr 10, 2024
RafaelGSS
added
the
fast-track
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
H4ad
approved these changes
Apr 10, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52452 ✔ Done loading data for nodejs/node/pull/52452 ----------------------------------- PR info ------------------------------------ Title doc: add Rafael to steward list (#52452) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:add-rafael-steward-april10 -> nodejs:main Labels doc, fast-track Commits 1 - doc: add Rafael to steward list Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/52452 Refs: https://github.com/nodejs-private/security-release/issues/22 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Moshe Atlow Reviewed-By: Richard Lau Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52452 Refs: https://github.com/nodejs-private/security-release/issues/22 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Moshe Atlow Reviewed-By: Richard Lau Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 10 Apr 2024 17:02:06 GMT ✔ Approvals: 4 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52452#pullrequestreview-1992355019 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52452#pullrequestreview-1992371968 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/52452#pullrequestreview-1992392097 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/52452#pullrequestreview-1992582811 ℹ This PR is being fast-tracked ✘ This PR needs to wait 44 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8637443818 |
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b4186ec |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52452 Refs: nodejs-private/security-release#22 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52452 Refs: nodejs-private/security-release#22 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs-private/security-release/issues/22