crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL #52217

codebytere · 2024-03-26T09:15:42Z

As in title. It's possible for NODE_EXTRA_CA_CERTS to work in a BoringSSL context, so there's no need to include that in the guard. This allows Electron users to leverage it.

nodejs-github-bot · 2024-03-26T09:15:47Z

Review requested:

@nodejs/startup

tniessen

This increases the number of #endif directives without changing the number of #if directives. You'll need to split the existing #if ... && ... into two separate directives in order to use separate #endif directives for the two conditions.

codebytere · 2024-03-26T11:04:02Z

@tniessen oops, forgot to push that 😅 fixed.

tniessen

On a side note, the commit message does not adhere to the guidelines, I'd suggest crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL or something along those lines.

src/node.cc

nodejs-github-bot · 2024-03-26T12:23:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57959/

src/node.cc

Co-authored-by: Yagiz Nizipli <[email protected]>

src/node.cc

Co-authored-by: Luigi Pinca <[email protected]>

nodejs-github-bot · 2024-04-11T08:28:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58264/

nodejs-github-bot · 2024-04-11T11:54:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58277/

nodejs-github-bot · 2024-04-11T14:46:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58284/

nodejs-github-bot · 2024-04-11T23:29:57Z

Landed in 28d68f3

PR-URL: #52217 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

aduh95 · 2024-04-30T23:19:59Z

Should this be labelled semver-minor?

PR-URL: #52217 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

nodejs/node#52217

* chore: bump node in DEPS to v20.13.0 * crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL nodejs/node#52217 * test: skip test for dynamically linked OpenSSL nodejs/node#52542 * lib, url: add a `windows` option to path parsing nodejs/node#52509 * src: use dedicated routine to compile function for builtin CJS loader nodejs/node#52016 * test: mark test as flaky nodejs/node#52671 * build,tools: add test-ubsan ci nodejs/node#46297 * src: preload function for Environment nodejs/node#51539 * chore: fixup patch indices * deps: update c-ares to 1.28.1 nodejs/node#52285 * chore: handle updated filenames - nodejs/node#51999 - nodejs/node#51927 * chore: bump node in DEPS to v20.13.1 * events: extract addAbortListener for safe internal use nodejs/node#52081 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * fs: add stacktrace to fs/promises nodejs/node#49849 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>

nodejs/node#52217

* chore: bump node in DEPS to v20.13.1 * chore: bump node in DEPS to v20.14.0 * crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL nodejs/node#52217 * test: skip test for dynamically linked OpenSSL nodejs/node#52542 * lib, url: add a `windows` option to path parsing nodejs/node#52509 * src: use dedicated routine to compile function for builtin CJS loader nodejs/node#52016 * test: mark test as flaky nodejs/node#52671 * build,tools: add test-ubsan ci nodejs/node#46297 * src: preload function for Environment nodejs/node#51539 * chore: fixup patch indices * deps: update c-ares to 1.28.1 nodejs/node#52285 * chore: handle updated filenames * events: extract addAbortListener for safe internal use nodejs/node#52081 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * fs: add stacktrace to fs/promises nodejs/node#49849 * chore: fixup patch indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>

* chore: bump node in DEPS to v20.13.1 * chore: bump node in DEPS to v20.14.0 * chore: update build_add_gn_build_files.patch * chore: update patches * chore: update patches * build: encode non-ASCII Latin1 characters as one byte in JS2C nodejs/node#51605 * crypto: use EVP_MD_fetch and cache EVP_MD for hashes nodejs/node#51034 * chore: update filenames.json * chore: update patches * src: support configurable snapshot nodejs/node#50453 * test: remove test-domain-error-types flaky designation nodejs/node#51717 * src: avoid draining platform tasks at FreeEnvironment nodejs/node#51290 * chore: fix accidentally deleted v8 dep * lib: define FormData and fetch etc. in the built-in snapshot nodejs/node#51598 * chore: remove stray log * crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL nodejs/node#52217 * test: skip test for dynamically linked OpenSSL nodejs/node#52542 * lib, url: add a `windows` option to path parsing nodejs/node#52509 * src: use dedicated routine to compile function for builtin CJS loader nodejs/node#52016 * test: mark test as flaky nodejs/node#52671 * build,tools: add test-ubsan ci nodejs/node#46297 * src: preload function for Environment nodejs/node#51539 * deps: update c-ares to 1.28.1 nodejs/node#52285 * chore: fixup * events: extract addAbortListener for safe internal use nodejs/node#52081 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * fs: add stacktrace to fs/promises nodejs/node#49849 * chore: fixup indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Cheng <[email protected]> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>

codebytere requested review from bnoordhuis and tniessen March 26, 2024 09:15

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 26, 2024

codebytere mentioned this pull request Mar 26, 2024

feat: support NODE_EXTRA_CA_CERTS electron/electron#41689

Merged

5 tasks

tniessen reviewed Mar 26, 2024

View reviewed changes

codebytere force-pushed the openssl-init-boringssl branch from 3b0f72c to 248c632 Compare March 26, 2024 11:04

tniessen reviewed Mar 26, 2024

View reviewed changes

src/node.cc Outdated Show resolved Hide resolved

codebytere force-pushed the openssl-init-boringssl branch from 248c632 to 452d594 Compare March 26, 2024 11:28

codebytere requested a review from tniessen March 26, 2024 11:28

tniessen approved these changes Mar 26, 2024

View reviewed changes

tniessen changed the title ~~crypto: BoringSSL can work with NODE_EXTRA_CA_CERTS~~ crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL Mar 26, 2024

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL

8904a61

codebytere force-pushed the openssl-init-boringssl branch from 452d594 to 8904a61 Compare March 26, 2024 12:02

tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2024

richardlau approved these changes Mar 26, 2024

View reviewed changes

addaleax approved these changes Mar 26, 2024

View reviewed changes

anonrig approved these changes Mar 26, 2024

View reviewed changes

src/node.cc Outdated Show resolved Hide resolved

Update src/node.cc

eaa7289

Co-authored-by: Yagiz Nizipli <[email protected]>

lpinca approved these changes Mar 26, 2024

View reviewed changes

src/node.cc Outdated Show resolved Hide resolved

Update src/node.cc

82b82e8

Co-authored-by: Luigi Pinca <[email protected]>

This comment was marked as outdated.

Sign in to view

tniessen approved these changes Apr 11, 2024

View reviewed changes

richardlau added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 11, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2024

nodejs-github-bot merged commit 28d68f3 into nodejs:main Apr 11, 2024

aduh95 mentioned this pull request Apr 30, 2024

2024-05-02, Version 22.1.0 (Current) #52768

Merged

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

codebytere added a commit to electron/electron that referenced this pull request May 8, 2024

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL

7a7297b

nodejs/node#52217

codebytere deleted the openssl-init-boringssl branch May 31, 2024 13:32

codebytere added a commit to electron/electron that referenced this pull request May 31, 2024

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL

202317c

nodejs/node#52217

codebytere added a commit to electron/electron that referenced this pull request May 31, 2024

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL

cbb262a

nodejs/node#52217

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL #52217

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL #52217

Uh oh!

codebytere commented Mar 26, 2024

Uh oh!

nodejs-github-bot commented Mar 26, 2024

Uh oh!

tniessen left a comment

Uh oh!

codebytere commented Mar 26, 2024

Uh oh!

tniessen left a comment

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 26, 2024

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 11, 2024

Uh oh!

nodejs-github-bot commented Apr 11, 2024

Uh oh!

nodejs-github-bot commented Apr 11, 2024

Uh oh!

nodejs-github-bot commented Apr 11, 2024

Uh oh!

aduh95 commented Apr 30, 2024

Uh oh!

Uh oh!

Uh oh!

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL #52217

crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL #52217

Uh oh!

Conversation

codebytere commented Mar 26, 2024

Uh oh!

nodejs-github-bot commented Mar 26, 2024

Uh oh!

tniessen left a comment

Choose a reason for hiding this comment

Uh oh!

codebytere commented Mar 26, 2024

Uh oh!

tniessen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 26, 2024

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 11, 2024

Uh oh!

nodejs-github-bot commented Apr 11, 2024

Uh oh!

nodejs-github-bot commented Apr 11, 2024

Uh oh!

nodejs-github-bot commented Apr 11, 2024

Uh oh!

aduh95 commented Apr 30, 2024

Uh oh!

Uh oh!