Skip to content

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jan 19, 2024

This is an automated update of undici to 6.5.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 19, 2024
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 6.4.0 deps: update undici to 6.5.0 Jan 26, 2024
@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jan 26, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@mcollina
Copy link
Member

@nodejs/build OS X seems to be down again.

@richardlau
Copy link
Member

@nodejs/build OS X seems to be down again.

Known issue, see nodejs/build#3616.

@mcollina
Copy link
Member

Should I land this manually and not have a complete CI run?
I don't seem to be able even to stop the current one.

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@UlisesGascon
Copy link
Member

Should I land this manually and not have a complete CI run?
I don't seem to be able even to stop the current one.

@mcollina the macos machines are available again, so they processing the CI pending queue. It can take a while
Screenshot 2024-01-30 at 20 29 38

@nodejs-github-bot
Copy link
Collaborator Author

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit dd4767f into main Feb 1, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Landed in dd4767f

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-undici branch February 1, 2024 09:30
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
PR-URL: nodejs#51527
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
PR-URL: nodejs#51527
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #51527
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants