Skip to content

worker,coverage: support V8 coverage generation #22928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

worker,coverage: support V8 coverage generation #22928

wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Sep 18, 2018 •
edited
Loading

This is currently blocked on #22927. (The first commit in this PR is included from there.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added blocked PRs that are blocked by other issues or PRs. worker Issues and PRs related to Worker support. coverage Issues and PRs related to native coverage support. labels Sep 18, 2018
@addaleax addaleax requested a review from bcoe September 18, 2018 11:15
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/923/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Sep 18, 2018
@addaleax addaleax removed c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Sep 18, 2018
@addaleax addaleax removed the blocked PRs that are blocked by other issues or PRs. label Sep 19, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17311/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 19, 2018 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17322/ (:heavy_check_mark:)

@addaleax
Copy link
Member Author

Landed in 0dbc8c8

@addaleax addaleax closed this Sep 21, 2018
@addaleax addaleax deleted the worker-coverage branch September 21, 2018 17:15
addaleax added a commit that referenced this pull request Sep 21, 2018
@addaleax
worker,coverage: support V8 coverage generation
0dbc8c8 
PR-URL: #22928
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
bcoe
bcoe reviewed Sep 21, 2018
View reviewed changes
test/parallel/test-v8-coverage.js
}

// outputs coverage from worker.
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for seeing this through @addaleax

targos pushed a commit that referenced this pull request Sep 25, 2018
@addaleax @targos
worker,coverage: support V8 coverage generation
7639390 
PR-URL: #22928
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@bcoe bcoe bcoe left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. coverage Issues and PRs related to native coverage support. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax @nodejs-github-bot @bcoe @jasnell @lpinca @cjihrig @BridgeAR @targos