tools: fix TypeError from test.py --time
#20368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculated durations are timedelta objects but the FormatTime function is expecting a number in seconds.
nodejs-github-bot
added
test
|
CI is green (!). |
|
@nodejs/build PTAL |
Trott
approved these changes
Apr 29, 2018
BridgeAR
added
the
author ready
trivikr
approved these changes
May 3, 2018
|
Landed in ab15198 |
trivikr
pushed a commit
that referenced
this pull request
May 3, 2018
Calculated durations are timedelta objects but the FormatTime function is expecting a number in seconds. PR-URL: #20368 Fixes: #20341 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Calculated durations are timedelta objects but the FormatTime function is expecting a number in seconds. PR-URL: #20368 Fixes: #20341 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Calculated durations are timedelta objects but the FormatTime function is expecting a number in seconds. PR-URL: #20368 Fixes: #20341 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
Calculated durations are timedelta objects but the FormatTime function is expecting a number in seconds. PR-URL: #20368 Fixes: #20341 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.
Fixes: #20341
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes