Skip to content

tools: treat SIGABRT as crash #19990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tools: treat SIGABRT as crash #19990

wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

Otherwise, potentially no output is shown for aborts.

Refs: #19903

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
tools: treat SIGABRT as crash
617843f 
Otherwise, potentially no output is shown for aborts.

Refs: nodejs#19903
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Apr 12, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Apr 13, 2018 •
edited
Loading

Landed in dadddcb 🎉

@BridgeAR BridgeAR closed this Apr 13, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 13, 2018
@addaleax @BridgeAR
tools: treat SIGABRT as crash
dadddcb 
Otherwise, potentially no output is shown for aborts.

PR-URL: nodejs#19990
Refs: nodejs#19903
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@addaleax addaleax deleted the sigabrt branch April 13, 2018 19:00
@addaleax
Copy link
Member Author

@BridgeAR Did this ever go through CI? I don’t think it’s causing issues, but it might be good to start a CI for master now if that’s not the case

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2018
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@addaleax @jasnell
tools: treat SIGABRT as crash
4f4e716 
Otherwise, potentially no output is shown for aborts.

PR-URL: #19990
Refs: #19903
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@addaleax @BridgeAR
tools: treat SIGABRT as crash
ae3f3d7 
Otherwise, potentially no output is shown for aborts.

PR-URL: nodejs#19990
Refs: nodejs#19903
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
addaleax added a commit that referenced this pull request Jun 29, 2018
@addaleax
tools: treat SIGABRT as crash
427124a 
Otherwise, potentially no output is shown for aborts.

PR-URL: #19990
Refs: #19903
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax @rvagg
tools: treat SIGABRT as crash
bf09b7a 
Otherwise, potentially no output is shown for aborts.

PR-URL: #19990
Refs: #19903
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@addaleax @BridgeAR @refack @bnoordhuis @jasnell @cjihrig @joyeecheung @gireeshpunathil @nodejs-github-bot