Skip to content

src: remove unused include in tty_wrap.h #16379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: remove unused include in tty_wrap.h #16379

wants to merge 1 commit into from

Conversation

@danbev
Copy link
Contributor

@danbev danbev commented Oct 22, 2017

This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: remove unused include in tty_wrap.h
494828c 
This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tty Issues and PRs related to the tty subsystem. labels Oct 22, 2017
@danbev
Copy link
Contributor Author

danbev commented Oct 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10902/

danbev added a commit to danbev/node that referenced this pull request Oct 25, 2017
@danbev
src: remove unused include in tty_wrap.h
6971f02 
This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

PR-URL: nodejs#16379
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danbev
Copy link
Contributor Author

danbev commented Oct 25, 2017

Landed in 6971f02

@danbev danbev closed this Oct 25, 2017
@danbev danbev deleted the unused-include-tty_wrap branch October 25, 2017 05:53
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@danbev @addaleax
src: remove unused include in tty_wrap.h
38148e3 
This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

PR-URL: nodejs/node#16379
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@danbev @gibfahn
src: remove unused include in tty_wrap.h
0727c36 
This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

PR-URL: #16379
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@danbev @gibfahn
src: remove unused include in tty_wrap.h
f0576c5 
This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

PR-URL: #16379
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@danbev @MylesBorins
src: remove unused include in tty_wrap.h
4127b4f 
This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

PR-URL: #16379
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@danbev @MylesBorins
src: remove unused include in tty_wrap.h
519d942 
This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

PR-URL: #16379
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@danbev @MylesBorins
src: remove unused include in tty_wrap.h
2f5edc6 
This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

PR-URL: #16379
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@danbev @addaleax
src: remove unused include in tty_wrap.h
7ae4285 
This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

PR-URL: nodejs/node#16379
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+2 more reviewers

@apapirovski apapirovski apapirovski approved these changes

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. tty Issues and PRs related to the tty subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.