[v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM

[liuxingbaoyu]

Version

v20.6.0

Platform

all

Subsystem

No response

What steps will reproduce the bug?

https://github.com/liuxingbaoyu/node-v20.6-bug

How often does it reproduce? Is there a required condition?

always

What is the expected behavior? Why is that the expected behavior?

node .\main.js
run
success

What do you see instead?

node .\main.js
run
run
success

Additional information

This should be the regression introduced by v20.6.

[nicolo-ribaudo]

Note that this is breaking@babel/core, and thus all the frameworks/project that use it. It would be great to prioritize it 🙏

[targos]

Can someone give a reproducible example? The code from https://github.com/liuxingbaoyu/node-v20.6-bug doesn't show the problem (it throws an error in mod/index.js).

[liuxingbaoyu]

Sorry, I forgot to push the second commit.
But the initial error is also different due to the regression.

[liuxingbaoyu]

Please try again, thanks!

[nicolo-ribaudo]

Right, that error happens because it runs twice. You can replace index.js with the following to not see the error:

console.log("RUNNING");
exports.File = 2;
require("./1");

[nicolo-ribaudo]

A minimal reproduction:

// index.mjs
import "./dep.cjs";

// dep.cjs
require("./dep.cjs");
console.log("RUNNING");

Running node index.mjs logs twice but it should log once.

[targos]

I have a repro. Starting to bisect.