error C2665: 'v8::ScriptOrigin::ScriptOrigin': no overloaded function could convert all the argument types

[oalfroukh]

Hi,

• I'm not sure if this is the right repo to report for this issue as I'm not sure who is responsible about it

• I was using electron v30.5.0 and when I tried to upgrade it to use v33.2.0 I got the below error wehn using electron-builder --config ./electron-builder.json --win --x64

• Trying to "overrides" "nan" to be 2.22.0 has no affect

C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\bin\HostX64\x64\CL.exe /c /I"C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node" /I"C:\Users\oalfroukh\.electron-gyp\33.2.0\src" /I"C:\Users\oalfroukh\.electron-gyp\33.2.0\deps\openssl\config" /I"C:\Users\oalfroukh\.electron-gyp\33.2.0\deps\openssl\openssl\include" /I"C:\Users\oalfroukh\.electron-gyp\33.2.0\deps\uv\include" /I"C:\Users\oalfroukh\.electron-gyp\33.2.0\deps\zlib" /I"C:\Users\oalfroukh\.electron-gyp\33.2.0\deps\v8\include" /I..\..\..\node_modules\nan /Z7 /nologo /W3 /WX- /diagnostics:column /MP /Ox /Ob2 /Oi /Ot /Oy /GL /D NODE_GYP_MODULE_NAME=helpers /D USING_UV_SHARED=1 /D USING_V8_SHARED=1 /D V8_DEPRECATION_WARNINGS=1 /D _GLIBCXX_USE_CXX11_ABI=1 /D ELECTRON_ENSURE_CONFIG_GYPI /D USING_ELECTRON_CONFIG_GYPI /D V8_COMPRESS_POINTERS /D V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE /D V8_31BIT_SMIS_ON_64BIT_ARCH /D V8_ENABLE_SANDBOX /D WIN32 /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _HAS_EXCEPTIONS=0 /D OPENSSL_NO_PINSHARED /D OPENSSL_THREADS /D OPENSSL_NO_ASM /D BUILDING_NODE_EXTENSION /D "HOST_BINARY=\"node.exe\"" /D _WINDLL /GF /Gm- /MT /GS /Gy /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR- /Fo"Release\obj\helpers\\win32\Helpers.obj" /Fd"Release\obj\helpers\vc143.pdb" /external:W3 /Gd /TP /wd4351 /wd4355 /wd4800 /wd4251 /wd4275 /wd4244 /wd4267 /FC /errorReport:queue /Zc:__cplusplus -std:c++20 ..\win32\Helpers.cc
  Helpers.cc
C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,23): error C2665: 'v8::ScriptOrigin::ScriptOrigin': no overloaded function could convert all the argument types [C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj]
  (compiling source file '../win32/Helpers.cc')
  C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-message.h(64,3):
  could be 'v8::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>,int,int,bool,int,v8::Local<v8::Value>,bool,bool,bool,v8::Local<v8::Data>)'
        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,23):      
        'v8::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>,int,int,bool,int,v8::Local<v8::Value>,bool,bool,bool,v8::Local<v8::Data>)': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Value>'
                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,47):
                'v8::Local<v8::Value>::Local': no overloaded function could convert all the argument types
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(424,1):
                        could be 'v8::Local<v8::Value>::Local(v8::Local<v8::Value> &&)'
                                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,47):
                                'v8::Local<v8::Value>::Local(v8::Local<v8::Value> &&)': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Value> &&'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,47):
                                        Reason: cannot convert from 'v8::Isolate *' to 'v8::Local<v8::Value>'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,47):
                                        Conversion requires a second user-defined-conversion operator or constructor
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(424,1):
                        or       'v8::Local<v8::Value>::Local(const v8::Local<v8::Value> &)'
                                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,47):
                                'v8::Local<v8::Value>::Local(const v8::Local<v8::Value> &)': cannot convert argument 1 from 'v8::Isolate *' to 'const v8::Local<v8::Value> &'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,47):
                                        Reason: cannot convert from 'v8::Isolate *' to 'const v8::Local<v8::Value>'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,47):
                                        Conversion requires a second user-defined-conversion operator or constructor
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(258,3):
                        or       'v8::Local<v8::Value>::Local(void)'
                                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,47):
                                'v8::Local<v8::Value>::Local': function does not take 1 arguments
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(261,3):
                        or       'v8::Local<v8::Value>::Local(v8::Local<S>)'
                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,47):
                        while trying to match the argument list '(v8::Isolate *)'
  C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,23):
  while trying to match the argument list '(v8::Isolate *, v8::Local<v8::Value>)'

C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,23): error C2665: 'v8::ScriptOrigin::ScriptOrigin': no overloaded function could convert all the argument types [C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj]
  (compiling source file '../win32/Helpers.cc')
  C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-message.h(64,3):
  could be 'v8::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>,int,int,bool,int,v8::Local<v8::Value>,bool,bool,bool,v8::Local<v8::Data>)'
        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,23):      
        'v8::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>,int,int,bool,int,v8::Local<v8::Value>,bool,bool,bool,v8::Local<v8::Data>)': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Value>'
                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,47):
                'v8::Local<v8::Value>::Local': no overloaded function could convert all the argument types
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(424,1):
                        could be 'v8::Local<v8::Value>::Local(v8::Local<v8::Value> &&)'
                                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,47):
                                'v8::Local<v8::Value>::Local(v8::Local<v8::Value> &&)': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Value> &&'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,47):
                                        Reason: cannot convert from 'v8::Isolate *' to 'v8::Local<v8::Value>'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,47):
                                        Conversion requires a second user-defined-conversion operator or constructor
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(424,1):
                        or       'v8::Local<v8::Value>::Local(const v8::Local<v8::Value> &)'
                                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,47):
                                'v8::Local<v8::Value>::Local(const v8::Local<v8::Value> &)': cannot convert argument 1 from 'v8::Isolate *' to 'const v8::Local<v8::Value> &'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,47):
                                        Reason: cannot convert from 'v8::Isolate *' to 'const v8::Local<v8::Value>'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,47):
                                        Conversion requires a second user-defined-conversion operator or constructor
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(258,3):
                        or       'v8::Local<v8::Value>::Local(void)'
                                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,47):
                                'v8::Local<v8::Value>::Local': function does not take 1 arguments
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(261,3):
                        or       'v8::Local<v8::Value>::Local(v8::Local<S>)'
                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,47):
                        while trying to match the argument list '(v8::Isolate *)'
  C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,23):
  while trying to match the argument list '(v8::Isolate *, v8::Local<v8::Value>, T)'
          with
          [
              T=int
          ]

C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,23): error C2665: 'v8::ScriptOrigin::ScriptOrigin': no overloaded function could convert all the argument types [C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj]
  (compiling source file '../win32/Helpers.cc')
  C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-message.h(64,3):
  could be 'v8::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>,int,int,bool,int,v8::Local<v8::Value>,bool,bool,bool,v8::Local<v8::Data>)'
        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,23):      
        'v8::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>,int,int,bool,int,v8::Local<v8::Value>,bool,bool,bool,v8::Local<v8::Data>)': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Value>'
                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,47):
                'v8::Local<v8::Value>::Local': no overloaded function could convert all the argument types
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(424,1):
                        could be 'v8::Local<v8::Value>::Local(v8::Local<v8::Value> &&)'
                                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,47):
                                'v8::Local<v8::Value>::Local(v8::Local<v8::Value> &&)': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Value> &&'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,47):
                                        Reason: cannot convert from 'v8::Isolate *' to 'v8::Local<v8::Value>'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,47):
                                        Conversion requires a second user-defined-conversion operator or constructor
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(424,1):
                        or       'v8::Local<v8::Value>::Local(const v8::Local<v8::Value> &)'
                                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,47):
                                'v8::Local<v8::Value>::Local(const v8::Local<v8::Value> &)': cannot convert argument 1 from 'v8::Isolate *' to 'const v8::Local<v8::Value> &'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,47):
                                        Reason: cannot convert from 'v8::Isolate *' to 'const v8::Local<v8::Value>'
                                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,47):
                                        Conversion requires a second user-defined-conversion operator or constructor
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(258,3):
                        or       'v8::Local<v8::Value>::Local(void)'
                                C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,47):
                                'v8::Local<v8::Value>::Local': function does not take 1 arguments
                        C:\Users\oalfroukh\.electron-gyp\33.2.0\include\node\v8-local-handle.h(261,3):
                        or       'v8::Local<v8::Value>::Local(v8::Local<S>)'
                        C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,47):
                        while trying to match the argument list '(v8::Isolate *)'
  C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,23):
  while trying to match the argument list '(v8::Isolate *, v8::Local<v8::Value>, T, T)'
          with
          [
              T=int
          ]

C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\win32\Helpers.cc(58,16): warning C4312: 'type cast': conversion from 'unsigned long' to 'HWND' of greater size [C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj]
Done Building Project "C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj" (default targets) -- FAILED.
Done Building Project "C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\binding.sln" (default targets) -- FAILED.

Build FAILED.

"C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\binding.sln" (default target) (1) ->
"C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj" (default target) (2) ->
(ClCompile target) ->
  C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\win32\Helpers.cc(58,16): warning C4312: 'type cast': conversion from 'unsigned long' to 'HWND' of greater size [C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj]


"C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\binding.sln" (default target) (1) ->
"C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj" (default target) (2) ->
(ClCompile target) ->
  C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(36,23): error C2665: 'v8::ScriptOrigin::ScriptOrigin': no overloaded function could convert all the argument types [C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj]
  C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(40,23): error C2665: 'v8::ScriptOrigin::ScriptOrigin': no overloaded function could convert all the argument types [C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj]
  C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\node_modules\nan\nan_scriptorigin.h(47,23): error C2665: 'v8::ScriptOrigin::ScriptOrigin': no overloaded function could convert all the argument types [C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj]

    1 Warning(s)
    3 Error(s)

BR,

[bimalkjha]

I am too facing same issue using using electron 33.x

../node_modules/nan/nan_scriptorigin.h: In constructor ‘Nan::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>)’:
../node_modules/nan/nan_scriptorigin.h:36:55: error: no matching function for call to ‘v8::ScriptOrigin::ScriptOrigin(v8::Isolate*, v8::Local<v8::Value>&)’
   36 |       v8::ScriptOrigin(v8::Isolate::GetCurrent(), name) {}
      |                                                       ^
In file included from /home/bjha/.cache/node-gyp/33.2.1/include/node/v8-script.h:20,
                 from /home/bjha/.cache/node-gyp/33.2.1/include/node/v8-debug.h:10,
                 from /home/bjha/.cache/node-gyp/33.2.1/include/node/v8-isolate.h:19,
                 from /home/bjha/.cache/node-gyp/33.2.1/include/node/v8-snapshot.h:9,
                 from /home/bjha/.cache/node-gyp/33.2.1/include/node/v8-context.h:15,
                 from /home/bjha/.cache/node-gyp/33.2.1/include/node/v8.h:26,

[gtritchie]

Discussed here: #978

FWIW I'm successfully using the workaround mentioned there (a postinstall step that comments out a line in nan.h).

[oalfroukh]

Hi @gtritchie

I got the below error now when I added that postinstall step that comments out a line in nan.h

    npm error   C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\node_modules\nan\nan.h(2618,8): error C2039: 'SetAccessor': is not a member of 'v8::ObjectTemplate' [C:\Users\oalfroukh\Desktop\electron_samples\electron-quick-start-main\electron-quick-start-main\native\helpers\build\helpers.vcxproj]

[gtritchie]

It's working for me. I'm building without errors on Mac, Windows, and Linux with that line commented out.

[oalfroukh]

Hi,
The issue is fixed on nan v2.22.2 so overrides the version to the latest version that's released 4 days ago(`v2.22.2) will fix the issue.