Skip to content

chore(deps): bump semver from 7.6.2 to 7.6.3 #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2024
Merged

chore(deps): bump semver from 7.6.2 to 7.6.3 #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"esbuild": "^0.21.0",
"eslint": "^8.57.0",
"proxy-from-env": "^1.1.0",
"semver": "^7.5.2",
"semver": "^7.6.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more in the camp of "We shouldn't touch package.json for minor updates" (fewer chances of git conflicts, and smaller diffs is always nicer to review), but no strong feelings

Suggested change
"semver": "^7.6.3",
"semver": "^7.5.2",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would generally agree, if dependencies are bumped mainly for the sake of... bumping them. In this case, the bump is very intentional, and we SPECIFICALLY want 7.6.3 or later. Then, you can backtrack why want 7.6.3 and not earlier versions more easily, because there's a trace of it in git blame. Sure, there's git blame of the lockfile, but that's hardly a human-readable format.

"supports-color": "^9.0.0",
"tar": "^6.2.1",
"tsx": "^4.16.2",
Expand Down
24 changes: 6 additions & 18 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,7 +1230,7 @@ __metadata:
esbuild: "npm:^0.21.0"
eslint: "npm:^8.57.0"
proxy-from-env: "npm:^1.1.0"
semver: "npm:^7.5.2"
semver: "npm:^7.6.3"
supports-color: "npm:^9.0.0"
tar: "npm:^6.2.1"
tsx: "npm:^4.16.2"
Expand Down Expand Up @@ -1286,19 +1286,7 @@ __metadata:
languageName: node
linkType: hard

"debug@npm:4, debug@npm:^4.1.1, debug@npm:^4.3.1, debug@npm:^4.3.2, debug@npm:^4.3.4":
version: 4.3.4
resolution: "debug@npm:4.3.4"
dependencies:
ms: "npm:2.1.2"
peerDependenciesMeta:
supports-color:
optional: true
checksum: 10c0/cedbec45298dd5c501d01b92b119cd3faebe5438c3917ff11ae1bff86a6c722930ac9c8659792824013168ba6db7c4668225d845c633fbdafbbf902a6389f736
languageName: node
linkType: hard

"debug@npm:^4.3.5":
"debug@npm:4, debug@npm:^4.1.1, debug@npm:^4.3.1, debug@npm:^4.3.2, debug@npm:^4.3.4, debug@npm:^4.3.5":
version: 4.3.5
resolution: "debug@npm:4.3.5"
dependencies:
Expand Down Expand Up @@ -3671,12 +3659,12 @@ __metadata:
languageName: node
linkType: hard

"semver@npm:^7.3.5, semver@npm:^7.5.2, semver@npm:^7.6.0":
version: 7.6.2
resolution: "semver@npm:7.6.2"
"semver@npm:^7.3.5, semver@npm:^7.6.0, semver@npm:^7.6.3":
version: 7.6.3
resolution: "semver@npm:7.6.3"
bin:
semver: bin/semver.js
checksum: 10c0/97d3441e97ace8be4b1976433d1c32658f6afaff09f143e52c593bae7eef33de19e3e369c88bd985ce1042c6f441c80c6803078d1de2a9988080b66684cbb30c
checksum: 10c0/88f33e148b210c153873cb08cfe1e281d518aaa9a666d4d148add6560db5cd3c582f3a08ccb91f38d5f379ead256da9931234ed122057f40bb5766e65e58adaf
languageName: node
linkType: hard

Expand Down