fix(nix-locate): respect color=always #237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--color=alwayshas been broken when sending stdout to a pipe since the move to owo-colors in #217.The issue is that even though the
colorarg would be set totrue, it still used.if_supports_color(Stream::Stdout, ...when printing which wouldn't emit color if stdout wasn't a tty regardless what the arg was set to. I've removed theattycheck and usedowo-colorsoverride functionality based on the value of--color.This does mean that the string slicing logic for the matched segment is run unconditionally on each match. I haven't run benchmarks but I assume the difference is negligible.