[algorithms] Overlap interface revision #925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now it accepts not only binary files, also ROI files with multiple labels. * Volumes can be handled in voxel units (as formerly) and mm3 * Keeps backwards compatibility of outputs and inputs
Member
|
@oesteban - can you add a real test for this? in algorithms we prefer real tests. |
Contributor
Author
|
@satra yes, I will try to add them ASAP 👍 |
Member
|
Pending merge on the tests. |
Contributor
Author
|
I've added some tests. What is annoying is that results are similar (but not very close, 2nd decimal) to the results I get with However, implementation is basically the same it was previously. |
chrisgorgo
added a commit
that referenced
this pull request
Oct 6, 2014
[algorithms] Overlap interface revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels.
NOTE: I've tested it with both ROI files and binary files, it'd be very easy to write some regression tests for this