-
Notifications
You must be signed in to change notification settings - Fork 536
FIX: Prevent double-collapsing of nested lists by OutputMultiObject #2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cloned traits are a subset of the original.
|
While this seems to resolve the reading of |
FIX: Improve collapse detection to correctly handle numpy arrays FIX: Uncollapse before modifying paths when loading results
Codecov Report
@@ Coverage Diff @@
## master #2673 +/- ##
==========================================
- Coverage 67.62% 67.61% -0.01%
==========================================
Files 340 340
Lines 43056 43076 +20
Branches 5329 5333 +4
==========================================
+ Hits 29116 29127 +11
- Misses 13238 13246 +8
- Partials 702 703 +1
Continue to review full report at Codecov.
|
|
@oesteban This is passing if you have a few minutes for review. |
|
I was at it right now :) |
|
Thanks. |
Summary
The saving/loading of results in
Nodecauses anOutputMultiObjectthat looks like[[x]]to be collapsed twice intox, as opposed to the expected[x].This PR detects collapses by performing a
clone_traits(), which also collapses such traits, and wraps those values in a list.Fixes #2670.
List of changes proposed in this PR (pull-request)
_protect_collapseshelper function that mimicstrait_get, but re-wraps collapsing traits in lists before returning the values.Acknowledgment