Skip to content

Conversation

@effigies
Copy link
Member

Follow-up to #2122.

Changes proposed in this pull request

  • Use consistent (CamelCase) column headers for all columns in pre-filter file
  • "SteadyState" => "NonSteadyStateOutlier" for accuracy
  • "cos" => "Cosine" and "poly" => "Legendre" for descriptive clarity

@chrisgorgo
Copy link
Member

any ideas why the tests are failing?

Copy link
Member

@chrisgorgo chrisgorgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the tests failing this looks good to me.

@effigies
Copy link
Member Author

effigies commented Aug 1, 2017

Bug with provenance tests. It's affecting all nipype builds, at the moment.

@effigies effigies merged commit 86c41d3 into nipy:master Aug 1, 2017
effigies added a commit to nipreps/niworkflows that referenced this pull request Aug 1, 2017
@effigies effigies deleted the enh/compcor_exclude branch August 1, 2017 16:50
@effigies effigies mentioned this pull request Aug 8, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants