Skip to content

Conversation

@chrisgorgo
Copy link
Member

No description provided.

@blakedewey
Copy link
Contributor

I think the documentation on the "Graph" plugins is a little weak and I always have trouble distinguishing the plugin functions. Maybe this would be a good time to update the docs on these, since we are adding more graph options.

@chrisgorgo
Copy link
Member Author

Good point!

On Mon, Jul 13, 2015 at 4:14 PM, Blake Dewey [email protected]
wrote:

I think the documentation on the "Graph" plugins is a little weak and I
always have trouble distinguishing the plugin functions. Maybe this would
be a good time to update the docs on these, since we are adding more graph
options.


Reply to this email directly or view it on GitHub
#1136 (comment).

@chrisgorgo
Copy link
Member Author

What about now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_without_submitting shouldn't apply to a graph plugin - that option is to ensure nodes can run on the monitoring/submitting node. in the graph plugin case, since the scheduler takes over, this check would be unnecessary. i know this was taken from the SGEgraph code (and i didn't review it closely enough :( ).

@chrisgorgo
Copy link
Member Author

I cleaned it up and added a small fix to SGEGraph

@satra
Copy link
Member

satra commented Jul 22, 2015

LGTM

@chrisgorgo chrisgorgo merged commit 9cfb703 into nipy:master Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants