-
Notifications
You must be signed in to change notification settings - Fork 54
[RTM] ENH: Add MRICoregRPT interface #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48e88b8 to
bfa3e48
Compare
Member
Author
|
I have no idea why the tests aren't running. I can build the docker image and run them fine locally. @oesteban could you have a look at some point? |
Contributor
|
Might be worth rerunning with SSH to debug interactively.
…On Fri, Sep 1, 2017 at 8:58 AM, Chris Markiewicz ***@***.***> wrote:
I have no idea why the tests aren't running. I can build the docker image
and run them fine locally. @oesteban <https://github.com/oesteban> could
you have a look at some point?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#195 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOkp5kx_j-bwSCz3_z4ypdjPM-r6I8_ks5seCm9gaJpZM4PJMCJ>
.
|
Member
Author
|
It seems to be a docker issue. Trying to run the docker image that gets built results in 255 exit code. :-/ |
e32843f to
72a7a60
Compare
72a7a60 to
0edf503
Compare
9f4d38e to
d776343
Compare
d776343 to
050eee8
Compare
oesteban
approved these changes
Sep 19, 2017
Member
oesteban
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: