fix(provideChildTranslateService): not calling the loader when the lazy loaded module is first loaded

[CarbonCollins]

Hi,

not sure if its just me doing something wrong, I have a module federated application that I worked with and recently updated to V17 to test things out.

out main/host application uses a custom loader and missing translation handler which is provided like so:

        provideTranslateService({
          missingTranslationHandler: provideMissingTranslationHandler(MissingTranslationHandler),
          loader: provideTranslateLoader(HostTranslationLoader)
        }),

Within our remote application that is lazy loaded later I have the following provided:

        provideChildTranslateService({
          extend: true,
          missingTranslationHandler: provideMissingTranslationHandler(MissingTranslationHandler),
          loader: provideTranslateLoader(RemoteTranslationLoader)
        })

The loader for the remote is slightly different in order to load the translation assets from a custom path that is hosted separatly.

The the host application first loads the host translation loader gets to work and loads all of the translations for the host no problem.

when i navigate to the remote application I can see that the child translate service is instantiated and has the correct lang an such set, however, this does not trigger the initial loading of the remote translations. This is also the same when the application changes language. The host loader kicks in and gets the new translations but the remote one does nothing...

Am i missing an initial bootstrap / event registration or do I need to do this manually in each remote to work?

Edit:

I can also add if in the constructor/init function of my remote / lazy loaded application and call this.translateService.use('en') I can see that the RemoteTranslationLoader does load the translations but it feels odd that I have to manually trigger this...

Minimal reproduction of the problem with instructions

1. Open the test-app
2. Open your chrome devTool
3. Go to the extended page
4. Change the lang
5. Only the extended loader will be fired

[rbalet]

Hi @CarbonCollins your implementation & understanding on how it should work is correct.

I could reproduce it in our code sample, so thanks a lot for pointing us this out !

Description

The loader does not seems to be triggered when it boots, but only when the .use() method is called.
The .use() method is called only when the lang is being provided.

Proposition

if the lang isn't passed inside the config, the children should fetch the one from the parent

[CarbonCollins]

Nice, good to know i'm not going too crazy :D Just a little :P

Is there anything I can do from my side to help resolve the bug?

[rbalet]

@CarbonCollins Hey, I honestly don't know. '^^

You could try to resolve it and submit a PR, but I'm not feeling confident on how to solve this one properly and have the feeling that @CodeAndWeb would be the best fit to solve this issue.

But this is up to you. 😘

[CarbonCollins]

Thats fair, ill have a look if I have time at work, we have plenty of other things to resolve before this is required for us :) If @CodeAndWeb gets around to starting this don't let me stop you :D and If I do find anything ill post here

[rbalet]

@CodeAndWeb & @CarbonCollins.

I've tried the following : #1596
Let me know if I'm heading into the right solution, and feel free to enhance the PR.

I won't have time to work on that in the next two weeks :/