Skip to content

Conversation

nginx-jack
Copy link
Collaborator

@nginx-jack nginx-jack commented Oct 10, 2024

Proposed changes

Add sidebar swapper.
Expected behaviour:

  • On visiting the page without having used useNewTheme, the current side bar should be visible
  • After running useNewTheme(true) in your browser console, the sidebar should be replaced with the text "Sidebar placeholder" and the new theme should be visible
  • Running useNewTheme(false) should revert back to the current styling
  • Refreshing the page should keep the same state as before the refresh, be it theme true or theme false

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@nginx-jack nginx-jack requested a review from a team October 10, 2024 13:31
@nginx-jack nginx-jack marked this pull request as ready for review October 10, 2024 13:31
Copy link
Collaborator

@lamATnginx lamATnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works when trying with Luke to show mainframe

@nginx-jack nginx-jack merged commit e9ef0a4 into main Oct 29, 2024
@nginx-jack nginx-jack deleted the sidebar-toggle-only branch July 31, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants