Skip to content

Conversation

danielledeleo
Copy link
Contributor

This PR is necessary so that inline styles for the main Hugo theme don't interfere with Mainframe styles.

Comment from assets/css/inline-overrides.css:

/*
 * These styles were previously defined inline in the theme as hacks. They
 * live here so we know where they came from.
 *
 * Where necessary, new classes were defined in their place so they don't 
 * interfere with the new theme CSS. (e.g. .override-sidebar-collapse)
 **/

Most inline shortcode styles were left alone for now.
Copy link
Contributor

@nginx-aoife nginx-aoife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing
Compared preview site to prod

  • No significant change in layout ✅
  • All features working as before ✅

@danielledeleo danielledeleo merged commit 88b032a into main Oct 2, 2024
@ADubhlaoich ADubhlaoich deleted the extracted-overrides branch October 14, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants