Add coveo jwt caching #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx-jack
requested review from
JTorreG,
travisamartin,
ADubhlaoich and
LukeBillington
as code owners
ADubhlaoich
approved these changes
Jan 21, 2025
lamATnginx
approved these changes
Jan 21, 2025
|
Reached out to security for approval on this approach, will update with response. |
|
Security suggested a HTTPOnly cookie if possible, but that's not possible for our setup without implementing a running backend (or adding a bunch of logic in NJS), so we're good to proceed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coveo jwt caching.
This change will store the coveo org id and token as a JWT in localstorage.
When the page is bootstrapping, it will check local storage for the token and check if the token is valid.
It will use the token from cache if it's still valid, or make a request for a new one if it has expired.
The goal of this is to stop the persistent reloading of the search input box on page change, and this seems to achieve that 👌 .
Note: Security wise, this JWT is already visible in plain text looking in the network tab. Given coveos strict CORS and short token life, storing this in local storage isn't an issue.