Reuse TowerClient to handle Fusion token requests

[jordeu]

Overview

This PR reuses the TowerClient logic to handle all license token requests, which will avoid the code from diverging in the future and fix the missing refresh token issue in the current implementation.

Implementation details

This pull request introduces significant changes to the TowerFusionToken class and its related components, focusing on simplifying the codebase and improving integration with the TowerClient. The updates remove redundant HTTP handling logic, streamline configuration validation, and enhance test coverage. Additionally, a new method is added to serialize license token requests into a map format.

Codebase Simplification:

• Integration with TowerClient: The TowerFusionToken class now uses the TowerClient for HTTP requests, removing custom HTTP client logic, retry policies, and related helper methods. This simplifies the code and centralizes HTTP handling. (plugins/nf-tower/src/main/io/seqera/tower/plugin/TowerFusionToken.groovy, [1] [2]
• Validation Removal: Configuration validation logic for endpoint and accessToken has been removed, relying instead on TowerClient to handle these concerns. (plugins/nf-tower/src/main/io/seqera/tower/plugin/TowerFusionToken.groovy, [1] [2]

Feature Enhancements:

• toMap Method in GetLicenseTokenRequest: A new method has been added to convert license token request objects into a map, facilitating integration with TowerClient. (plugins/nf-tower/src/main/io/seqera/tower/plugin/exchange/GetLicenseTokenRequest.groovy, plugins/nf-tower/src/main/io/seqera/tower/plugin/exchange/GetLicenseTokenRequest.groovyR32-R43)

Test Updates:

• Test Refactoring: Removed tests that validated endpoint and accessToken extraction logic, as these functionalities are now handled by TowerClient. New tests were added to validate workflow creation and token retrieval using the updated TowerFusionToken implementation. (plugins/nf-tower/src/test/io/seqera/tower/plugin/TowerFusionEnvTest.groovy, plugins/nf-tower/src/test/io/seqera/tower/plugin/TowerFusionEnvTest.groovyL46-R91)

[netlify]

✅ Deploy Preview for nextflow-docs-staging canceled.

Name	Link
🔨 Latest commit	ac3de33
🔍 Latest deploy log	https://app.netlify.com/projects/nextflow-docs-staging/deploys/686240a44d787b0008ccf8be

[pditommaso]

Not sure this can easily back-ported to older branches

[jordeu]

Not sure this can easily back-ported to older branches

I checked with 24.04, and it is no problem to backport it because the TowerClient and TowerFactory interfaces are the same.

[pditommaso]

Thanks for looking into this @jordeu, it looks good however I think it would be better to keep using TowerClient exclusively for Platform telemetry, and do not use for other tasks.

The main raison is that, in principle, Fusion can be used even without activating Platform telemetry (provided the access token is provided). This PR instead, implicitly enables the telemetry even if not required.

https://github.com/nextflow-io/nextflow/pull/6207/files#diff-a253f546ca68a21c3b2176ffa1135ab6b87d9b63215c94fbb2cca1cfe95be128R103

I've opened a separate PR to add the JWT token logic in the current implementation #6231

It's true that there's some code duplication, however this already a problem for other clients. see this and this, other than this.

For this problem we may introduce a new http client class dedicated to properly handle this need in across all implementations.

[pditommaso]

It turns our Platform telemetry is a desired requirement. Therefore this implementation makes more sense.

[pditommaso]

Ouch getting this in the CI tests

WARN: Unable to serialize key=; value=[product:fusion, version:2.4, workflowId:null, workspaceId:null]; type=java.util.HashMap -- Cause: Index: 1, Size: 1
[fe/2ee5bc] Submitted process > RNASEQ:FASTQC (FASTQC on lung)
WARN: Unable to validate Fusion license - reason: Invalid response: https://api.cloud.seqera.io/license/token/ [400] Unexpected error while processing request - Error ID: 2d2bVF6Gnd9EEIsjvwpCBr -- {"message":"Unexpected error while processing request - Error ID: 2d2bVF6Gnd9EEIsjvwpCBr"}

[pditommaso]

I've reverted this PR 👉 b8a7722