Skip to content

Conversation

@hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Oct 29, 2025

Overview

Add the following Supportability metrics:

  • Supportability/DistributedTrace/PartialGranularity/<partial granularity type>/Span/Instrumented - The total number of span events that were instrumented and would have been recorded (if the trace was full granularity) before partial granularity dropped them.
  • Supportability/DistributedTrace/PartialGranularity/<partial granularity type>/Span/Kept - The total number of span events that were recorded and kept by partial granularity (aka that were not dropped).
  • Supportability/<language>/PartialGranularity/<type> - This MUST be sent when partial granularity is enabled. The pipeline will add a tag to the entity when this metric is sent so the DT UI can indicate partial granularity tracing is on.

TimPansino and others added 16 commits October 23, 2025 22:14
* fix(aiomysql): avoid wrapping pooled connections multiple times

* Move and rewrite regression test

* Tweak implementation of fix

---------

Co-authored-by: Tim Pansino <[email protected]>
Bumps the github_actions group with 4 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact), [actions/download-artifact](https://github.com/actions/download-artifact), [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) and [github/codeql-action](https://github.com/github/codeql-action).


Updates `actions/upload-artifact` from 4.6.2 to 5.0.0
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@ea165f8...330a01c)

Updates `actions/download-artifact` from 5.0.0 to 6.0.0
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@634f93c...018cc2c)

Updates `astral-sh/setup-uv` from 7.1.1 to 7.1.2
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](astral-sh/setup-uv@2ddd2b9...8585678)

Updates `github/codeql-action` from 4.30.9 to 4.31.0
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@16140ae...4e94bd1)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github_actions
- dependency-name: actions/download-artifact
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github_actions
- dependency-name: astral-sh/setup-uv
  dependency-version: 7.1.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github_actions
- dependency-name: github/codeql-action
  dependency-version: 4.31.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github_actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Timothy Pansino <[email protected]>
* fix(aiomysql): avoid wrapping pooled connections multiple times

* Move and rewrite regression test

* Tweak implementation of fix

---------

Co-authored-by: Tim Pansino <[email protected]>
Bumps the github_actions group with 4 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact), [actions/download-artifact](https://github.com/actions/download-artifact), [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) and [github/codeql-action](https://github.com/github/codeql-action).


Updates `actions/upload-artifact` from 4.6.2 to 5.0.0
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@ea165f8...330a01c)

Updates `actions/download-artifact` from 5.0.0 to 6.0.0
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@634f93c...018cc2c)

Updates `astral-sh/setup-uv` from 7.1.1 to 7.1.2
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](astral-sh/setup-uv@2ddd2b9...8585678)

Updates `github/codeql-action` from 4.30.9 to 4.31.0
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@16140ae...4e94bd1)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github_actions
- dependency-name: actions/download-artifact
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github_actions
- dependency-name: astral-sh/setup-uv
  dependency-version: 7.1.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github_actions
- dependency-name: github/codeql-action
  dependency-version: 4.31.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github_actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Timothy Pansino <[email protected]>
@hmstepanek hmstepanek requested a review from a team as a code owner October 29, 2025 00:36
@hmstepanek hmstepanek changed the base branch from main to develop-hybrid-core-tracing October 29, 2025 00:37
@github-actions
Copy link

MegaLinter analysis: Error

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.92s
✅ MARKDOWN markdownlint 7 0 0 0 1.19s
❌ PYTHON ruff 948 0 1 0 1.07s
✅ PYTHON ruff-format 948 3 0 0 0.36s
✅ YAML prettier 15 0 0 0 1.56s
✅ YAML v8r 15 0 0 5.69s
✅ YAML yamllint 15 0 0 0.7s

Detailed Issues

❌ PYTHON / ruff - 1 error
::error title=Ruff (F821),file=newrelic/core/application.py,line=1377,col=103,endLine=1377,endColumn=120::newrelic/core/application.py:1377:103: F821 Undefined name `partial_gran_type`

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@hmstepanek hmstepanek changed the title Add metrics Add Supportability metrics for partial granularity tracing Oct 29, 2025
@mergify mergify bot added the tests-failing Tests failing in CI. label Oct 29, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 89.21569% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.81%. Comparing base (59633ac) to head (2e077c6).
⚠️ Report is 3 commits behind head on develop-hybrid-core-tracing.

Files with missing lines Patch % Lines
newrelic/config.py 51.72% 14 Missing ⚠️
newrelic/core/node_mixin.py 94.91% 1 Missing and 2 partials ⚠️
newrelic/core/agent.py 50.00% 2 Missing ⚠️
newrelic/core/data_collector.py 71.42% 1 Missing and 1 partial ⚠️
newrelic/api/transaction.py 98.27% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           develop-hybrid-core-tracing    #1560      +/-   ##
===============================================================
+ Coverage                        81.76%   81.81%   +0.05%     
===============================================================
  Files                              207      207              
  Lines                            23943    24081     +138     
  Branches                          3796     3820      +24     
===============================================================
+ Hits                             19576    19702     +126     
- Misses                            3101     3105       +4     
- Partials                          1266     1274       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-failing Tests failing in CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants