This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[QuanitztionModifier] initialize per channel scales and zps to correct shape #1738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug found by @anmarques
pytorch does not initialize channel wise qat scales and zero points to their final shape, just to (1,). this adds a patch to expand them to their expected shape
test_plan:
@anmarques to fully reproduce and verify
existing unit tests pass
manual inspection of initialized scales and zero points: