Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

Satrat
Copy link

@Satrat Satrat commented Sep 8, 2023

Fixing issues caused by the upgrade to SparseZoo V2:

  1. Model class stores recipes in a list, updated optim/helpers.py to reflect this change This was handled instead by updating SparseZoo to restore the default functionality: neuralmagic/sparsezoo@f2cf607
  2. Changed multiple filename searches to use - instead of _ to reflect change in sparsezoo
  3. Removed deprecated test case that searches for original.md recipe (these have been renamed to recipe.md). Replaced with a test that searches for a non-default recipe name

@Satrat Satrat marked this pull request as ready for review September 11, 2023 17:08
bfineran
bfineran previously approved these changes Sep 13, 2023
Copy link
Contributor

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking OK to land, however we need to get recipes.default back to supported so that ?recipe_type in stubs will work reliably

@Satrat Satrat requested a review from bfineran September 15, 2023 17:23
@Satrat Satrat merged commit e5faef5 into main Sep 15, 2023
@Satrat Satrat deleted the sa/sparsezoo_v2_compat branch September 15, 2023 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants