This repository was archived by the owner on Jun 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 156
[LLAMA] KV Cache Injection #1709
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks great @dsikka . We need to figure out the fix for the positions and then we are good to go! |
dbogunowicz
reviewed
Aug 23, 2023
dbogunowicz
reviewed
Aug 23, 2023
dbogunowicz
reviewed
Aug 24, 2023
bfineran
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great - see comment
dbogunowicz
previously approved these changes
Aug 28, 2023
dbogunowicz
approved these changes
Aug 29, 2023
bfineran
approved these changes
Aug 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for LLAMA2 KV Cache Injection:
configs.py
ends
attribute is updated. This is required for the positions injection to work properlyTesting:
With this injected model, we can currently run the model in the pipeline using ORT:
Output: