Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

Satrat
Copy link

@Satrat Satrat commented Jul 13, 2023

  1. Adding tmp_path_retention_policy = "none" to pyproject.toml so that pytest deletes its temp files after every session, freeing up disk space.
  2. Because pytest takes care of deleting its own files, we can exclude them from the file size check in conftest.py

Testing

run make test TARGETS=transformers

Old Behavior

check_for_created_files() fails with error:

Failed: failed on teardown with "AssertionError: 2506.184633255005 megabytes of temp files created
 in temp directory during pytest run. 

New Behavior

tests pass without errors

Copy link
Contributor

@dbogunowicz dbogunowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbarbuzzi pinging you, so that you can rerun tests after this lands :)

@Satrat Satrat merged commit 162e6cc into main Jul 14, 2023
@Satrat Satrat deleted the fix-temp-file-size-test branch July 14, 2023 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants