Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Deprecate Py37 #1611

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Deprecate Py37 #1611

merged 2 commits into from
Jun 8, 2023

Conversation

rahul-tuli
Copy link
Member

Python 3.7 reaches it's EOL in ~2 weeks https://endoflife.date/python
This PR deprecated our support for the same

@rahul-tuli
Deprecate py37
3aea5b7 
Remove `_nullcontext` as from 3.7+ there is a similar method in standard library
@rahul-tuli rahul-tuli self-assigned this Jun 8, 2023
dsikka
dsikka reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the logic here just changing the Python version until the tests pass?

@rahul-tuli
Copy link
Member Author

Was the logic here just changing the Python version until the tests pass?

Yes!

dsikka
dsikka approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahul-tuli rahul-tuli merged commit ff98ca0 into main Jun 8, 2023
@rahul-tuli rahul-tuli deleted the deprecate-py37 branch June 8, 2023 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbogunowicz dbogunowicz Awaiting requested review from dbogunowicz

@KSGulin KSGulin Awaiting requested review from KSGulin

2 more reviewers

@bfineran bfineran bfineran approved these changes

@dsikka dsikka dsikka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rahul-tuli rahul-tuli

Labels
mle-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahul-tuli @bfineran @dsikka