Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

corey-nm
Copy link
Contributor

@corey-nm corey-nm commented Nov 11, 2022

Test plan:

  1. unit tests pass locally on python 3.9, torch 1.132
  2. Ran onnx model comparison between our ModuleExporter on 1.12.1 and 1.13.1 on the following models:
    1. resnet50
    2. bert for QA

@github-actions
Copy link

@bfineran @rahul-tuli assigned for review

@corey-nm corey-nm requested a review from dbogunowicz November 23, 2022 14:08
Copy link
Contributor

@KSGulin KSGulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Glad it's a mostly painless upgrade. Integration tests are failing because a deepsparse nightly for 1.5 hasn't been built yet. Would like to wait for the 1.5 deepsparse nightly build and integration tests to pass before landing, if possible

@bfineran bfineran merged commit a69c208 into main Feb 14, 2023
@bfineran bfineran deleted the torch-1.13-support branch February 14, 2023 15:30
@bfineran
Copy link
Contributor

Nice! Glad it's a mostly painless upgrade. Integration tests are failing because a deepsparse nightly for 1.5 hasn't been built yet. Would like to wait for the 1.5 deepsparse nightly build and integration tests to pass before landing, if possible

page refreshed late before force merging - given tests pass locally am okay keeping and reverting if issues are caught since nightly may take longer to get cut

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants