Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

dbogunowicz
Copy link
Contributor

@dbogunowicz dbogunowicz commented Jun 5, 2023

Changes

  1. Added the conftests so that after running any test target, the total size of files created after running the test suite can be: up to four new files for the root directory, and up to 150mb of created data for the temp directory.
  2. Audited the most important paths for /src and /tests, made sure that when model's inputs are being altered, by default the happen changes "in-place"

@dbogunowicz dbogunowicz marked this pull request as ready for review June 7, 2023 16:17
bfineran
bfineran previously approved these changes Jun 9, 2023
Copy link
Contributor

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, however not sure on naming "inplace" since that seems to imply the model is kept in memory to me

@dbogunowicz dbogunowicz changed the base branch from main to 1.4 June 12, 2023 16:46
@dbogunowicz dbogunowicz changed the base branch from 1.4 to main June 12, 2023 16:46
@dbogunowicz dbogunowicz dismissed bfineran’s stale review June 12, 2023 16:46

The base branch was changed.

@dbogunowicz dbogunowicz changed the base branch from main to 1.4 June 13, 2023 05:32
@dbogunowicz dbogunowicz changed the base branch from 1.4 to main June 13, 2023 05:33
@dbogunowicz dbogunowicz requested review from markurtz and KSGulin June 13, 2023 06:55
Copy link
Contributor

@KSGulin KSGulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting here: Maybe a rebase is needed

@bfineran bfineran merged commit fed2f73 into main Jun 13, 2023
@bfineran bfineran deleted the feature/damian/do_not_save_to_tmp branch June 13, 2023 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants