Fix bugs in Optuna integration with the prompt2model demo script #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neubig
reviewed
Oct 31, 2023
zhaochenyang20
approved these changes
Oct 31, 2023
|
@neubig The Jupyter notebook was not affected by the earlier changes - right now the notebook does not run hyperparameter selection. I will add this in a subsequent PR, but want to fix this (broken) capability in the demo script first. Regarding the integration tests, I agree that we need this somewhat urgently. I've filed an issue for this and will tackle this next week: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#315 introduced automated hyperparameter selection in Prompt2Model via Optuna, but this PR did not work with the demo script out-of-the-box. This PR fixes those bugs.
References
N/A
Blocked by
N/A