feat: Allow plugin to run onSuccess with toml setting or env var LIGHTHOUSE_RUN_ON_SUCCESS #570
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
aitchiss
commented
Apr 13, 2023
|
|
||
| export default function lighthousePlugin(inputs) { | ||
| // Run onPostBuild by default, unless RUN_ON_SUCCESS is set to true | ||
| // Run onPostBuild by default, unless LIGHTHOUSE_RUN_ON_SUCCESS env var is set to true, or run_on_success is specified in plugin inputs |
Contributor
Author
There was a problem hiding this comment.
I noticed we have an inputs option for run_on_success and in the end I felt like at that level it made sense not to prefix with lighthouse_, but happy to change to match the env var if preferred (I was on the fence 😄 )
aitchiss
changed the title
jackbrewer
approved these changes
Apr 13, 2023
Contributor
jackbrewer
left a comment
jackbrewer
left a comment
There was a problem hiding this comment.
All looking good! 🚀
We should remember to test through UI installation once the new version is available too
Contributor
Author
Good point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(went for a long PR title just for the sake of the changelog since we're going to cut a release with this)
Renames the env var to run on success to make this ready for experimental use.
Steps to validate:
run_on_success. Plugin should runonPostBuildas beforerun_on_successto'true'in the site'stomlfile and deploy. Plugin should run on success and results should be shown in the UI when readyLIGHTHOUSE_RUN_ON_SUCCESS='TRUE'. Plugin should run on success and results should be shown in the UI when ready