feat: add support for unregistering event handlers #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor callback management to use `Map` so that we can unregister handlers without changing the current behavior. Co-authored-by: Cassidy Williams <[email protected]>
|
Deploy Success! Built with commit 61bd509 |
mraerino
reviewed
Jul 2, 2020
Contributor
mraerino
left a comment
mraerino
left a comment
There was a problem hiding this comment.
why not use a Set? Should do the same right?
Contributor
Author
|
@mraerino no real reason — we were thinking of key/val when we walked through solutions, and I didn't actually realize that Set had |
cassidoo
added
the
type: feature
Contributor
|
@jlengstorf, I added some tests and allowed doing Also handled a case where calling If we're all good with the changes I think this is ready to merge. |
Contributor
Author
|
thanks for adding those tests, @erezrokah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor callback management to use
Mapso that we can unregisterhandlers without changing the current behavior.