Skip to content

fix(function-builder): report build errors #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2020
Merged

fix(function-builder): report build errors #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be2f339
fix(function-builder): report build errors
erezrokah Jul 15, 2020
d1d1497
fix(function-builder): improve log messages
erezrokah Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 31 additions & 15 deletions src/commands/dev/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,33 @@ async function startDevServer(settings, log) {
return ps
}

const getBuildFunction = functionBuilder =>
async function build() {
this.log(
`${NETLIFYDEVLOG} Function builder ${chalk.yellow(functionBuilder.builderName)} ${chalk.magenta(
'building'
)} functions from directory ${chalk.yellow(functionBuilder.src)}`
)

try {
await functionBuilder.build()
this.log(
`${NETLIFYDEVLOG} Function builder ${chalk.yellow(functionBuilder.builderName)} ${chalk.green(
'finished'
)} building functions from directory ${chalk.yellow(functionBuilder.src)}`
)
} catch (error) {
const errorMessage = (error.stderr && error.stderr.toString()) || error.message
this.log(
`${NETLIFYDEVLOG} Function builder ${chalk.yellow(functionBuilder.builderName)} ${chalk.red(
'failed'
)} building functions from directory ${chalk.yellow(functionBuilder.src)}${
errorMessage ? ` with error:\n${errorMessage}` : ''
}`
)
}
}

class DevCommand extends Command {
async run() {
this.log(`${NETLIFYDEV}`)
Expand Down Expand Up @@ -492,21 +519,10 @@ class DevCommand extends Command {
`${NETLIFYDEVWARN} This is a beta feature, please give us feedback on how to improve at https://github.com/netlify/cli/`
)

const debouncedBuild = debounce(
async () => {
this.log(
`${NETLIFYDEVLOG} Function builder ${chalk.yellow(
functionBuilder.builderName
)} building functions from ${chalk.yellow(functionBuilder.src)}`
)
await functionBuilder.build()
},
300,
{
leading: true,
trailing: true,
}
)
const debouncedBuild = debounce(getBuildFunction(functionBuilder).bind(this), 300, {
leading: true,
trailing: true,
})

await debouncedBuild()

Expand Down
1 change: 1 addition & 0 deletions src/utils/serve-functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ function createHandler(dir) {
Object.keys(require.cache).forEach(k => {
delete require.cache[k]
})
console.log(`${NETLIFYDEVLOG} ${path} ${action}, successfully reloaded!`)
}
const watcher = chokidar.watch(dir, { ignored: /node_modules/ })
watcher.on('change', clearCache('modified')).on('unlink', clearCache('deleted'))
Expand Down