-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add diode-replay-dryrun helper #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Go test coverage
Total coverage: 76.7% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Introduces a new CLI tool for replaying dry-run JSON files to a Diode service and updates project dependencies.
- Adds
diode-replay-dryrun
CLI incmd/diode-replay-dryrun/main.go
with flags for files, target, app info, and OAuth2 credentials. - Updates
go.mod
to makegolang.org/x/net
a direct dependency. - Documents installation and usage of the new CLI in
README.md
.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
go.mod | Promote golang.org/x/net to a direct requirement |
cmd/diode-replay-dryrun/main.go | Implement the CLI tool for ingesting dry-run JSON files |
README.md | Add documentation and usage examples for the new CLI helper |
Comments suppressed due to low confidence (3)
cmd/diode-replay-dryrun/main.go:27
- [nitpick] The variable name
version
is ambiguous; consider renaming it toappVersion
for consistency with the flag name and to improve clarity.
version := flag.String("app-version", "", "Application version used when ingesting the dry-run messages")
cmd/diode-replay-dryrun/main.go:22
- Consider adding unit or integration tests for the CLI tool to verify flag parsing and ingestion behavior.
func main() {
README.md:179
- [nitpick] The example target path (
/diode
) differs from the flag description example (/diodet
); update one for consistency.
--target grpc://localhost:8080/diode \
Co-authored-by: Michal Fiedorowicz <[email protected]>
This pull request introduces a new CLI tool,
diode-replay-dryrun
, to replay dry-run files generated by theDryRunClient
and send them to a Diode service. It also updates the project dependencies ingo.mod
. Below are the most important changes:Addition of the
diode-replay-dryrun
CLI ToolREADME.md
explaining the purpose of thediode-replay-dryrun
tool, installation instructions, and usage examples. The tool supports ingesting multiple JSON files and provides flexibility in specifying OAuth2 credentials via flags or environment variables.main.go
file for the CLI tool, which includes:diode
SDK.Dependency Updates
go.mod
Changes: Updated thegolang.org/x/net
dependency to be a direct requirement instead of indirect. This ensures compatibility with the new CLI tool.