Skip to content

Conversation

@dimitri
Copy link

@dimitri dimitri commented Jul 21, 2025

Change to always allow auth hook to run
because we want to reject password based login
for databricks identities.

@dimitri dimitri requested review from MMeent and tristan957 July 21, 2025 12:33
@dimitri
Copy link
Author

dimitri commented Jul 21, 2025

I wonder if we can include the patch as-is or if we need to have a conditional setup of the skip_password_auth local variable there? Maybe conditional on the DatabricksAuthentication_hook pointer being non-null?

Copy link
Member

@tristan957 tristan957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@dimitri dimitri force-pushed the cherry-pick/a73a764a32a branch from 88e7988 to 5e4f391 Compare July 25, 2025 09:58
Change to always allow auth hook to run
because we want to reject password based login
for databricks identities.

Corresponding hadron PR for CI:
https://github.com/databricks-eng/hadron/pull/752
@dimitri dimitri force-pushed the cherry-pick/a73a764a32a branch from 5e4f391 to 2094921 Compare July 25, 2025 09:59
@MMeent MMeent changed the title [Hadron] Always run databricks auth hook (#27) [Hadron] Always run databricks auth hook Jul 25, 2025
@dimitri dimitri merged commit a42351f into REL_16_STABLE_neon Jul 30, 2025
5 checks passed
@dimitri dimitri deleted the cherry-pick/a73a764a32a branch July 30, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants