Improve Record#get(String key) complexity to O(1) #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous impl gives O(n) complexity because of index lookup in keys list. As the API of two Record#get methods are so similar, it is a valid assumption that the performance of two methods shall be the same. This PR introduces a lookup map to use one extra small space to improve `Record#get(String key)` complexity from O(n) to O(1).
gjmwoods
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous impl gives O(n) complexity because of index lookup in keys list. As the API of two Record#get methods are so similar, it is a valid assumption that the performance of two methods shall be the same.
This PR introduces a lookup map to use one extra small space to improve
Record#get(String key)complexity from O(n) to O(1).