Make channel auto-read management to work on routing driver #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the injected
RoutingResponseHandlerhides the auto-read management capabilities of the delegatedPullAllResponseHandlerand results in nested queries in a single transaction. The problem only applies to routing driver and was originally fixed with #528.This PR removes the previously introduced
AutoReadManagingResponseHandlerinterface and makes the capability a part of theResponseHandlerinterface with default methods. BothPullAllResponseHandlerandRoutingResponseHandleroverrides the default implementation and the latter delegates the request to the wrapped handler.