Make sessioin.reset thread-safe #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
1.1-thread-safe-reset
branch
2 times, most recently
from
786f858 to
b758757
Compare
zhenlineo
changed the title
zhenlineo
force-pushed
the
1.1-thread-safe-reset
branch
from
4b1d351 to
c9c890f
Compare
added 2 commits
September 8, 2016 12:18
Sync on `enqueue` and `flush` to avoid sending `reset` and other messages at the same time. Also changed response handler stream collector queue to be concurrent queue so that adding into the queue (sending) and removing from the queue (receiving) can be done safely concurrently. Keep `ack_fail` muted when `reset` is already send but not replied yet.
zhenlineo
force-pushed
the
1.1-thread-safe-reset
branch
from
c9c890f to
21dedff
Compare
… tx in the reseted tx. Sync on tx.markToClose and tx.run to enforce no more statement in the current tx when tx is already failed (reset).
zhenlineo
force-pushed
the
1.1-thread-safe-reset
branch
from
21dedff to
58177f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enqueueandflushto avoid sendingresetand other messages at the same time.ack_failmuted whenresetis already send but not replied yet.tx.markToCloseandtx.runto enforce no more statement in the current tx, if tx is already failed (reset).