-
Notifications
You must be signed in to change notification settings - Fork 14
Inlines antlr4 package from upstream #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently the JS runtime sometimes returns (and mangles) the global `window` object instead of a proper InputStream. This is prevented by using the `new` keyword in all cases.
…s available on Lexer prototype for use in lexer actions (this.SOME_MODE) like in Java actions, Utils.escapeWhiteSpace uses regex for global replace (was replacing only first occurnce of \n etc).
For JavaScript runtime, Interval class constructor assume start and stop to be number.
The usage of this method was removed in commit 51edf3cece13b42b8419c7d2587a4e2beeb05fd9, but the parameter remained.
JavaScript parse tree visitor: check if ctx.children is non-null in visitChildren
Signed-off-by: Alex Miller <[email protected]>
90d4a0a
to
67e5fb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's hope we get a new release from antlr soon 🤞
fb98c15
to
64476b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave the PR open for now and wait for an official release. At least it's easier to rebase changes instead of doing all the process of adding antlr4 and adjusting the build scripts etc again.
If they don't release a new antlr4 before our NODES conference, we can merge this the week before that.
64476b2
to
27ec9ff
Compare
What
Inlines the antlr4 Javascript upstream package in the repository
Why
Because we contributed a performance improvement that has yet not made it into a usable release. This is intended to be temporary. We want for users not to find perfomance issues when they use the language support.
How
This has been done by doing:
and then inside this repo locally: