-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade @angular/common from 12.0.4 to 12.2.17 #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade @angular/common from 12.0.4 to 12.2.17. See this package in npm: @angular/common See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/2d91292c-60d2-4a88-81bb-1a1c40995cf5?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, intends to update the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to upgrade @angular/common. However, it incorrectly downgrades the package from ^15.0.0 to ^12.2.17. This introduces a critical version mismatch with other @angular/* packages, which are on version 15. Such a mismatch will likely break the application's build or cause runtime errors. The change should be reverted to maintain version consistency across all Angular framework packages.
| "dependencies": { | ||
| "@angular/animations": "^15.0.0", | ||
| "@angular/common": "^15.0.0", | ||
| "@angular/common": "^12.2.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change downgrades @angular/common to version 12.2.17, creating a version mismatch with other @angular/* packages that are on version 15.0.0. It is critical for Angular applications that all framework packages (@angular/core, @angular/common, @angular/compiler, etc.) use the same major version. This inconsistency will likely lead to build failures or runtime errors. This change should be reverted to keep all @angular packages on version 15.
| "@angular/common": "^12.2.17", | |
| "@angular/common": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@angular/animations": "^15.0.0", | ||
| "@angular/common": "^15.0.0", | ||
| "@angular/common": "^12.2.17", | ||
| "@angular/compiler": "^15.0.0", | ||
| "@angular/core": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep Angular packages on the same major version
The commit downgrades @angular/common to ^12.2.17 while all other Angular runtime packages remain on ^15.0.0. Angular packages declare peer dependencies on matching major versions, so installing this set produces peer dependency conflicts and will either fail npm install or result in multiple copies of @angular/common being bundled. Any build that links @angular/core@15 with @angular/common@12 will likely fail at compile time or hit runtime errors. The dependency should stay on 15.x or the rest of the Angular stack should be upgraded/downgraded together.
Useful? React with 👍 / 👎.
Snyk has created this PR to upgrade @angular/common from 12.0.4 to 12.2.17.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 36 versions ahead of your current version.
The recommended version was released 3 years ago.
Release notes
Package name: @angular/common
-
12.2.17 - 2022-11-22
-
12.2.16 - 2022-01-27
-
12.2.15 - 2021-12-15
-
12.2.14 - 2021-12-01
-
12.2.13 - 2021-11-03
-
12.2.12 - 2021-10-27
-
12.2.11 - 2021-10-20
-
12.2.10 - 2021-10-13
-
12.2.9 - 2021-10-06
-
12.2.8 - 2021-09-30
-
12.2.7 - 2021-09-22
-
12.2.6 - 2021-09-15
-
12.2.5 - 2021-09-08
-
12.2.4 - 2021-09-01
-
12.2.3 - 2021-08-25
-
12.2.2 - 2021-08-18
-
12.2.1 - 2021-08-11
-
12.2.0 - 2021-08-04
-
12.2.0-rc.0 - 2021-07-28
-
12.2.0-next.3 - 2021-07-21
-
12.2.0-next.2 - 2021-07-14
-
12.2.0-next.1 - 2021-06-30
-
12.2.0-next.0 - 2021-06-24
-
12.1.5 - 2021-08-04
-
12.1.4 - 2021-07-28
-
12.1.3 - 2021-07-21
-
12.1.2 - 2021-07-14
-
12.1.1 - 2021-06-30
-
12.1.0 - 2021-06-24
-
12.1.0-next.6 - 2021-06-17
-
12.1.0-next.5 - 2021-06-09
-
12.1.0-next.4 - 2021-06-02
-
12.1.0-next.3 - 2021-05-26
-
12.1.0-next.2 - 2021-05-19
-
12.1.0-next.1 - 2021-05-05
-
12.0.5 - 2021-06-16
-
12.0.4 - 2021-06-09
from @angular/common GitHub release notesImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: