Small optimizations to combine #2032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a) Avoid copying lists in executemany_void: while some callers provide an iterator, others were already providing a list and in that case we had to copy it b) Avoid unpacking and re-packing contexts In total this shaves about 10% of the combine time in pyca/cryptography's CI
|
Thanks! |
|
My pleasure! I have an idea for a bigger perf win, but we'll see if it pans
out.
All that is necessary for evil to succeed is for good people to do nothing.
…On Sun, Aug 17, 2025, 12:50 PM Ned Batchelder ***@***.***> wrote:
Merged #2032 <#2032> into master.
—
Reply to this email directly, view it on GitHub
<#2032 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBERKAEAAD4JS3AX42D3OCXFJAVCNFSM6AAAAACEDCKVICVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJZGE4TCOJUGM2DQMQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
nedbat
added a commit
that referenced
this pull request
Aug 17, 2025
|
Combining has had a number of performance problems over the years. Looking forward to what you have. |
nedbat
added a commit
that referenced
this pull request
Aug 17, 2025
|
The core idea is "avoid going sqlite3 -> python -> sqlite3" by using |
|
This is now released as part of coverage 7.10.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) Avoid copying lists in executemany_void: while some callers provide an iterator, others were already providing a list and in that case we had to copy it
b) Avoid unpacking and re-packing contexts
In total this shaves about 10% of the combine time in pyca/cryptography's CI