Use set instead of list for arcs_executed, fixes poor performance #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! Do you have any stats on the size of the repo and the speed up? |
nedbat
added a commit
that referenced
this pull request
Dec 4, 2024
Speedup went from 730 seconds ("cant-wait-that-long-will-do-control-C"), to 13 seconds, for coverage xml. |
|
This is now released as part of coverage 7.6.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes very poor performance in "coverage.xml" for a large-ish code base, which I traced to the
arcs_missingprocedure. (Could probably improve further using set difference.)