-
Notifications
You must be signed in to change notification settings - Fork 2
Hackathon: Check Compatibility Matrix #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This adds a checker for the Compatibility Matrix docs. It tries to determine the minimum/maximum version of Nautobot from the Pyproject.toml (as the min/max version in the __init__.py could be going away). If you provide the --fix flag, it will add or update the line for the compatibility. This only checks the current version, it can't go back in time and check others. This also assumes that the last line is the version, which is the example, but may not be true in every repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a chance to review the code yet. Just some initial comments.
Co-authored-by: Gary Snider <[email protected]>
Co-authored-by: Gary Snider <[email protected]>
Co-authored-by: Gary Snider <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have time at the end of the sprint could you see if this could be trimmed down? This is a lot of code to add to the tasks.py
Co-authored-by: Gary Snider <[email protected]>
What's Changed
This adds a checker for the Compatibility Matrix docs. It tries to determine the minimum/maximum version of Nautobot from the Pyproject.toml (as the min/max version in the init.py could be going away). If you provide the --fix flag, it will add or update the line for the compatibility. This only checks the current version, it can't go back in time and check others. This also assumes that the last line is the version, which is the example, but may not be true in every repo.
EDIT:
I purposefully parse the pyproject.toml and compatibility_matrix.md with read instead of using a library like toml so that no additional packages need to be installed in the invoke library.
To Do