Allow multiple click listeners on iOS #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I spent some time updating the plugin to the NS community plugin format and added this PR manually. The changes were specifically added in this commit: |
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
This change allows to set multiple click listeners on iOS. I know there is a workaround by using
onMapEventfunction andclickas event name to set multiple listeners for a specific layer, but it's not a solution if a user wants to listen to multiple layers on the same callback. So the user may want to implement his own click logic. I should mention that for some reason current implementation ofsetOnMapClickListenerdoes not even work with 1 click listener on iOS, but this change will fix it too. I'm not sure if this should be done on Android too, so please let me know if it's the case.