TypeError: androidLocation.getProvider is not a function

[LaKing]

System.err: An uncaught Exception occurred on "main" thread.
System.err: Calling js method onLocationChanged failed
System.err: TypeError: androidLocation.getProvider is not a function
System.err: 
System.err: StackTrace:
System.err: locationFromAndroidLocation(file: app/webpack:/Hangmaffia/node_modules/@nativescript-community/gps/gps.android.js:101:0)
System.err: 	at onLocationChanged(file: app/webpack:/Hangmaffia/node_modules/@nativescript-community/gps/gps.android.js:36:0)
System.err: 	at com.tns.Runtime.callJSMethodNative(Native Method)
System.err: 	at com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1302)
System.err: 	at com.tns.Runtime.callJSMethodImpl(Runtime.java:1188)
System.err: 	at com.tns.Runtime.callJSMethod(Runtime.java:1175)
System.err: 	at com.tns.Runtime.callJSMethod(Runtime.java:1153)
System.err: 	at com.tns.Runtime.callJSMethod(Runtime.java:1149)
System.err: 	at com.tns.gen.android.location.LocationListener.onLocationChanged(LocationListener.java:24)
System.err: 	at android.location.LocationManager$LocationListenerTransport$1.operate(LocationManager.java:3196)
System.err: 	at android.location.LocationManager$LocationListenerTransport$1.operate(LocationManager.java:3193)
System.err: 	at com.android.internal.listeners.ListenerExecutor.lambda$executeSafely$0(ListenerExecutor.java:127)
System.err: 	at com.android.internal.listeners.ListenerExecutor$$ExternalSyntheticLambda0.run(Unknown Source:8)
System.err: 	at android.os.Handler.handleCallback(Handler.java:938)
System.err: 	at android.os.Handler.dispatchMessage(Handler.java:99)
System.err: 	at android.os.Looper.loopOnce(Looper.java:226)
System.err: 	at android.os.Looper.loop(Looper.java:313)
System.err: 	at android.app.ActivityThread.main(ActivityThread.java:8582)
System.err: 	at java.lang.reflect.Method.invoke(Native Method)
System.err: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:563)
System.err: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1133)
System.err: java.lang.reflect.InvocationTargetException
System.err: 	at java.lang.reflect.Method.invoke(Native Method)
System.err: 	at com.tns.NativeScriptUncaughtExceptionHandler.uncaughtException(NativeScriptUncaughtExceptionHandler.java:58)
System.err: 	at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1073)
System.err: 	at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1068)
System.err: 	at java.lang.Thread.dispatchUncaughtException(Thread.java:2200)
System.err: Caused by: java.lang.IllegalArgumentException: org.nativescript.Hangmaffia: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
System.err: Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
System.err: 	at android.app.PendingIntent.checkFlags(PendingIntent.java:382)
System.err: 	at android.app.PendingIntent.getActivityAsUser(PendingIntent.java:465)
System.err: 	at android.app.PendingIntent.getActivity(PendingIntent.java:451)
System.err: 	at android.app.PendingIntent.getActivity(PendingIntent.java:415)
System.err: 	at com.tns.ErrorReport.startPendingErrorActivity(ErrorReport.java:157)
System.err: 	at com.tns.ErrorReport.startActivity(ErrorReport.java:136)
System.err: 	... 5 more

Which platform(s) does your issue occur on?

I see this corrently on the latest Android version, with a physical device.
Android 12

Please, provide the following version numbers that your issue occurs with:

• CLI: Nativescript 8.1.4
• Cross-platform modules: 8.1.5

{
  "name": "Hangmaffia",
  "main": "app/app.js",
  "version": "1.0.0",
  "private": true,
  "dependencies": {
    "@nativescript-community/ble": "^3.0.29",
    "@nativescript-community/gps": "^3.1.0",
    "@nativescript/background-http": "^5.0.2",
    "@nativescript/camera": "^5.0.9",
    "@nativescript/core": "~8.1.1",
    "@nativescript/theme": "~3.0.1",
    "nativescript-audio": "^6.2.6",
    "nativescript-barcodescanner": "^4.0.1",
    "nativescript-nfc": "^5.0.0",
    "nativescript-vibrate": "^4.0.1",
    "nativescript-vue": "~2.9.0",
    "vuex": "^3.6.2"
  },
  "devDependencies": {
    "@nativescript/android": "8.1.1",
    "@nativescript/ios": "8.1.0",
    "@nativescript/webpack": "~5.0.0",
    "nativescript-dev-typescript": "^0.10.0",
    "nativescript-vue-template-compiler": "~2.9.0"
  }
}

Code

const gps = new GPS();

        gps.debug = true;
        const auth = await gps.isAuthorized();
        
        let location = await gps.getCurrentLocation({
            timeout: 2000,
        });

The app is crashing here.

If using skipPermissionCheck: true then the app doesn't crash, but there are no gps coordinates.

[farfromrefug]

@LaKing i have fixed the issue in 3.1.1 however it means the native side reported a "null" location which should not happen. Maybe you are missing permissions

[LaKing]

Thank you @farfromrefug ... I added myself to your sponsors .)

[farfromrefug]

@LaKing wow thank you! Dont hesitate to find me on discord if you have issues with getting locations on android 12.
Can we close this?

[LaKing]

@farfromrefug
Yes, the error is gone now ... my app still crashes, but at least there are no build errors now.
Let's meet on the plugins channel! ...

Thanks!!

[LaKing]

Reproducing in a minimal code

ns create my-tab-vue --template @nativescript/template-tab-navigation-vue
cd my-tab-vue
tns plugin add @nativescript-community/gps

Edit AndroidManifest to add permissions

  <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
  <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />

<application ...

Edit AndroidManifest to add within the application block

<activity
            android:exported="true"
...

Edit app/components/App.vue and in the script tag put the following content

import Items from "./Items.vue";
import Browse from "./Browse.vue";
import Search from "./Search.vue";
import { GPS } from "@nativescript-community/gps";
export default {
    components: {
        Items,
        Browse,
        Search,
    },
    created() {
        console.log("------------@ created--------------");
        async function test() {
            console.log("----------- @ test---------------");

            const gps = new GPS();

            gps.debug = true;

            if (!gps.isEnabled()) {
                console.log("---------- @ Location not enabled, requesting. -----------");
                return gps
                    .authorize(true)
                    .then(() => gps.enable())
                    .then(() => gps.isEnabled());
            }

            const auth = await gps.isAuthorized();

            console.log(" --------------- GPS getLocation: authorized", auth, "--------------");

            const location = await gps.getCurrentLocation({
                timeout: 2000,
                //skipPermissionCheck: true
            });
            console.log("------------ @ location--------------", location);
        }
        test();
    },
};

Eventually edit ```app.js``

Vue.config.silent=false;

With a physical android device connected run, ...

tns run

The application requests the GPS permissions.
Once the permission is given, restart the application / run tns run again
it will crash on sturtup after our GPS getLocation: authorized true
.. and then crashes at every subsequent startup.

tns debug android

I'm using the 3.1.1 version and the plugin is failing to return my location on android. It works fine on iOS. I'm using the latest alpha versions of cli, android, and core. I'm seeing this in my sdk 31 emulator and on my samsung phone - Android 12. I also ask for permissions when the app starts and allow when using the app. I am seeing the error listed above:
System.err: Calling js method onLocationChanged failed
System.err: TypeError: androidLocation.getProvider is not a function

I'm requesting the location as follows (I'm not setting skipPermissionCheck: true) but I don't know what the default is.
SelectedPageService.gps.getCurrentLocation(
{ desiredAccuracy: CoreTypes.Accuracy.high, maximumAge: 5000, timeout: 5000 }).then((location) => {
if (location) {
console.log("updating location to latitude: " + location.latitude + " longitude: " + location.longitude);
} else {
console.log("current location returned as null");
}

[LaKing]

@NachmanRoss you could contact @farfromrefug or other maintainers on discord, and debug the issue. The code for the minimal reproduction is above. ....

Would be nice to get this plugin working, I'm using another GPS plugin for now.

[farfromrefug]

@NachmanRoss you need to debug this. in the error stack it tells you where the error happens. there add a console.log of the androidLocation before the access to getProvider to see what is androidLocation. We need to know

[LaKing]

@farfromrefug Since the problem can be reproduced in an empty project, it does not make sense to ask users of the plugin to debug this in their projects. The plugin is broken in general, and not in a specific project.

I agree with LaKing. I only have one place where I call the plugin to get the location and the code for that is shown above. I also for permission to use it in this one place:
if (!SelectedPageService.gps.isEnabled()) {
return SelectedPageService.gps
.authorize(true)
.then(() => SelectedPageService.gps.enable())
.then(() => SelectedPageService.gps.isEnabled());
} else {
return Promise.resolve(true);
}

The error that I see in the log is when the android app is launched after being sent into background in this code from my app.ts file:
Application.on(Application.uncaughtErrorEvent, (args) => {
console.log("Uncaught Error: " + args.error.stack);
if (args.android) {
console.log("Nativescript Error: " + args.android);
} else {
console.log("Nativescript Error: " + args.ios);
}
});

So I never call the getProvider myself. It is being triggered when the app is brought into the foreground on android. It's probably happening during the getCurrentLocation call and is probably something that the android app is losing a pointer to when it is sent to the background.

[farfromrefug]

@LaKing @NachmanRoss i have that plugin working in production in around five apps. and me have sessions running in background for.more than 8 hours.
there are many reasons why this might not work for you which i cant always reproduce.
bit if you dont want to help sure dont i cant force you.

about the issue i am helping blind here. did you add everyhting necessary in your manifest file ?

I'm not unwilling to help but I don't know how to help. I've literally posted the only two places that I explicitly call the plugin. Both are localized to one class. One call to get authorization and the other call to getCurrentLocation. The trace log that is printed by the Application.on(Application.uncaughtErrorEvent doesn't mention my class or my use of getCurrentLocation. So I'm at a loss.
My androidManifest has the following entries:


When the app starts (for the first time after a new install), I'm asked to grant permission and I select "when the app is in use" and "Fine Location". I don't need the gps running in background so I don't ask for that permission. I only try to get the location when the user goes to the app's main menu. The action is probably also triggered when the device is brought to the foreground. This error didn't occur in the past and I believe started happening when I switched to the latest alpha versions of nativescript. It works fine with iOS.

I'm willing to install a debug version of the plugin with more error messages and try that but otherwise I'm not sure where to begin to look on my own. None of the statements listed in the trace log are from my classes or code. They're all from within the plugin and its internal calls.

[LaKing]

@farfromrefug can you please check if you can reproduce the issue with the minimal code for reproduction?

Reproducing in a minimal code

ns create my-tab-vue --template @nativescript/template-tab-navigation-vue cd my-tab-vue tns plugin add @nativescript-community/gps

Edit AndroidManifest to add permissions

  <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
  <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />

<application ...

Edit AndroidManifest to add within the application block

<activity
            android:exported="true"
...

Edit app/components/App.vue and in the script tag put the following content

import Items from "./Items.vue";
import Browse from "./Browse.vue";
import Search from "./Search.vue";
import { GPS } from "@nativescript-community/gps";
export default {
    components: {
        Items,
        Browse,
        Search,
    },
    created() {
        console.log("------------@ created--------------");
        async function test() {
            console.log("----------- @ test---------------");

            const gps = new GPS();

            gps.debug = true;

            if (!gps.isEnabled()) {
                console.log("---------- @ Location not enabled, requesting. -----------");
                return gps
                    .authorize(true)
                    .then(() => gps.enable())
                    .then(() => gps.isEnabled());
            }

            const auth = await gps.isAuthorized();

            console.log(" --------------- GPS getLocation: authorized", auth, "--------------");

            const location = await gps.getCurrentLocation({
                timeout: 2000,
                //skipPermissionCheck: true
            });
            console.log("------------ @ location--------------", location);
        }
        test();
    },
};

Eventually edit ```app.js``

Vue.config.silent=false;

With a physical android device connected run, ...

tns run

The application requests the GPS permissions. Once the permission is given, restart the application / run tns run again it will crash on sturtup after our GPS getLocation: authorized true .. and then crashes at every subsequent startup.

tns debug android