Skip to content

Should set UnderlyingType when use Template #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Should set UnderlyingType when use Template #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CommandLineUtils/Attributes/OptionAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,11 @@ internal CommandOption Configure(CommandLineApplication app, PropertyInfo prop)
LongName = longName,
ShortName = longName.Substring(0, 1),
ValueName = prop.Name.ToConstantCase(),
UnderlyingType = prop.PropertyType,
};
}

option.UnderlyingType = prop.PropertyType;

Configure(option);

option.Description ??= prop.Name;
Expand Down
6 changes: 6 additions & 0 deletions test/CommandLineUtils.Tests/DefaultHelpTextGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ SomeNullableEnumArgument nullable enum arg desc.
Allowed values are: None, Normal, Extreme.
-enumOpt4|--verb4[:<VERB4>] nullable enum option desc.
Allowed values are: None, Normal, Extreme.
-enumOpt5|--verb5 <VERB5> enum option desc.
Allowed values are: None, Normal, Extreme.
Default value is: None.
-?|-h|--help Show help information.

",
Expand Down Expand Up @@ -255,6 +258,9 @@ public class MyApp
[Option(CommandOptionType.SingleOrNoValue, ShortName = "enumOpt4", Description = "nullable enum option desc.")]
public SomeEnum? Verb4 { get; set; }

[Option("-enumOpt5 | --verb5 <VERB5>", Description = "enum option desc.")]
public SomeEnum Verb5 { get; set; }

[Argument(0, Description = "string arg desc.")]
public string SomeStringArgument { get; set; }

Expand Down