-
Notifications
You must be signed in to change notification settings - Fork 166
Add albyhub (v1.15.0) #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! Did you make the tarball when you tried the community install? It requires a very specific format from the mynode sdk to install right. It's rarely used since most apps are just integrated the way you added this. I'll try to take a closer look soon and include in the v0.3.36 release (v0.3.35 is about to go out). |
Yes
I used SDK
Could I deliver you my tar.gz for inspection somehow? Or open issue, or does it matter if this gets into official anyhow?
Thank you very much. |
c787cba
to
60c288f
Compare
[X] now works for me. |
ec07455
to
5750f3f
Compare
"name": "GitHub", | ||
"link": "https://github.com/getAlby/hub" | ||
}, | ||
"category": "bitcoin_app", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suite better to
"category": "lightning_app",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to lightning_app
I could change this to Dynamic/Community App, so the MyNodeBTC files would not be touched at all. And also update Hub version too. |
"download_type": "source", | ||
"download_source_url": "https://github.com/getAlby/hub/archive/refs/tags/{VERSION}.tar.gz", | ||
"download_binary_url": { | ||
"aarch64": "https://github.com/getAlby/hub/releases/download/{VERSION}/albyhub-Server-Linux-aarch64.tar.bz2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set all these URLs to "unused" or something since the download will be skipped. See jam.json for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
rootfs/standard/usr/share/mynode_apps/albyhub/scripts/uninstall_albyhub.sh
Outdated
Show resolved
Hide resolved
echo $PYBLOCK_VERSION > $PYBLOCK_LATEST_VERSION_FILE | ||
echo $WARDENTERMINAL_VERSION > $WARDENTERMINAL_LATEST_VERSION_FILE | ||
echo $WARDENTERMINAL_VERSION > $WARDENTERMINAL_LATEST_VERSION_FILE | ||
echo $ALBYHUB_VERSION > $ALBYHUB_LATEST_VERSION_FILE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed. Dynamic apps don't need to go here. I should add a comment in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. Removed addition that is not needed.
systemctl stop albyhub | ||
docker rmi albyhub | ||
docker rmi ghcr.io/getalby/hub:$ALBYHUB_VERSION | ||
rm -rf /mnt/hdd/mynode/albyhub/.albyhub-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to delete the data during a reinstall? I would normally add a button to the settings page to clean an apps data. Uninstall / reinstall normally don't clear out storage on the data drive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. This removed.
Let's make clean app data button, too.
Fix albyhub.service: no syslog (btw mynode_sdk .service file needs updateting) Update albyhub.png - Use GetAlby Brand Kit logo
Need to implement backup
Update albyhub.json
Fix albyhub.service: no syslog (btw mynode_sdk .service file needs updateting) Update albyhub.png - Use GetAlby Brand Kit logo
Need to implement backup
Dynamics apps json takes care of firewall settings so removing this
fac0904
to
a6f7010
Compare
Fix docker image removal
Update check_app_versions.py Update mynode_app_versions.sh
non-used file
This works for me Clear data button is not implemented. I'd like to implement App Data Management (backup & restore + clear/remove data) onto API separately. And then call (Remove App Data) API from App Info page. |
As reminder, this was requested on ticket |
Description
Adds light weight application which is liked by Lightning community. With albyHub people can use other non-local blockchain depending bitcoin & lnd lightning nodes. I think adding albyHub would raise interrest of many people towards MyNodeBTC.
Uninstall removes albyHub data, which is a bit inconvenient. Also I couldn't get app shown on
Customize Application Versions and front pages either.
I could not install tar.gz from Community apps UI - I get error:
I could fix those, if there's some docs I'd need to study.
Checklist
List of test device(s)
Raspi4
Feel free to modify and please comment.