Another minor fix after #3760

[FileEX]

No description provided.

[TheNormalnij]

Did you check all fields between m_fTimeCanRun and m_bRenderWeapon ?

[FileEX]

Did you check all fields between m_fTimeCanRun and m_bRenderWeapon ?

Yeah, it looks good

[Dutchman101]

1 comment was addressed, and 1 comment is pending with that it may or may not be addressed. Normally we'd wait for TheNormalnij to leave final feedback, but due to team/organisatorial reasons we have to merge it now to be able to get a new build (Build server/signing related), or else there might not be a new nightly for who knows how long.

The purported fix is against the last known issue that stands in the way of a finally stable build, which we've been working towards for the past 2 weeks with QA & testing. We'll see as we will now build a new nightly, and test it, besides seeing what TheNormalnij has to input tomorrow/if a follow-up change is needed, or if it will confirm we'll be looking at a stable build.

Note: the whole PR is for an issue that's been discussed in dev discord, a remote player desync.

[TheNormalnij]

Yeah, it looks good

Did you check how MTA uses these fields?

[FileEX]

Yeah, it looks good

Did you check how MTA uses these fields?

I know what you mean. The thing is that now all the fields up to the "flags" field, where m_pad2 was, have moved. However, the previous behavior was incorrect because e.g. this piece of code

((CPlayerInfoSA*)pGame->GetPlayerInfo())->GetInterface()->PlayerPedData.m_nChosenWeapon = weaponSlot;

Instead of referring to the real field, chosenWeapon (0x20) actually referred to the sprintEnergy (0x1C) field, which was not present in the interface. I don't think the current behavior is incorrect, on the contrary, the previous behavior was incorrect.