Skip to content

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Apr 10, 2024

Moved over some proprietary files from the core repository. I set up the workspace and enabled the following commands:

pnpm install
pnpm deduplicate
pnpm build
pnpm run --filter=@app/next-app dev
pnpm run --filter=@app/vite-app dev
pnpm run --filter=@app/next-app build
pnpm run --filter=@app/vite-app build

Next step:

  • enable the CI checks
  • enable the generateProptypes script
  • try and do a dry run on the release scripts
  • try to add one Material UI component in the apps (referring the @mui/material@next as external dependency)

@mnajdova mnajdova mentioned this pull request Apr 10, 2024
@oliviertassinari
Copy link
Member

Is this going to keep the git history like @michaldudak did for Base UI?

@mnajdova
Copy link
Member Author

mnajdova commented Apr 11, 2024

Yes, I did the same here, keeping the history the following directories:

packages/pigment-css-nextjs-plugin
packages/pigment-css-react
packages/pigment-css-unplugin
packages/pigment-css-vite-plugin
packages/pigment-nextjs-plugin
packages/pigment-vite-plugin
packages/pigment-unplugin
packages/pigment-react
packages/zero-next-plugin
packages/zero-runtime
packages/zero-tag-processor
packages/zero-vite-plugin
apps/

The history available: https://github.com/mui/pigment-css/commits/master/

This PR starts with setting up everything, workspace, scripts, etc, similar to mui/base-ui#1

@mnajdova mnajdova requested a review from michaldudak April 11, 2024 08:16
@mnajdova
Copy link
Member Author

GitHub is strange, I can't see my last commits 😕

@brijeshb42
Copy link
Contributor

It's showing Processing Updates at the top. So it might take a while before showing the commits.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any major issues. It's definitely worth setting up the CI as soon as possible to run checks on PRs.

@oliviertassinari oliviertassinari added the internal Behind-the-scenes enhancement. Formerly called “core”. label Apr 11, 2024
@mnajdova
Copy link
Member Author

I am closing the PR, I pushed the branch directly, GH seems to be very slow/buggy. Here is the commit: 18da3fc I will proceed with the CI checks.

@mnajdova mnajdova closed this Apr 12, 2024
@mnajdova
Copy link
Member Author

I am closing the PR, I pushed the branch directly, GH seems to be very slow/buggy. Here is the commit: 18da3fc I will proceed with the CI checks.

Alright, the issue is that I created the fork when the repository was private, and I didn't change my own fork to public. I am creating another fork as public, this should resolve future issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Behind-the-scenes enhancement. Formerly called “core”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants